Search for more object classes when listing groups and users.

[ggreer]

This fixes some issues with LDAP servers that have less common object classes for users & groups.

Summary by CodeRabbit

• New Features

  • Enhanced LDAP group and user filtering capabilities.
  • Improved user classification based on account types during LDAP searches.

• Bug Fixes

  • Resolved issues with group and user filters to accommodate additional object classes.

• Documentation

  • Updated documentation to reflect changes in filtering logic and user resource handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant modifications to the LDAP handling logic within the pkg/connector/group.go and pkg/connector/user.go files. In group.go, a new constant groupObjectClasses consolidates various group object classes, enhancing the groupFilter and groupIdFilter for more flexible LDAP queries. In user.go, the userFilter is updated to include additional object classes, and new logic is introduced to classify user accounts based on LDAP attributes. These changes improve the filtering and classification capabilities for both groups and users.

Changes

File	Change Summary
pkg/connector/group.go	- Introduced groupObjectClasses constant. - Updated groupFilter and groupIdFilter to use groupObjectClasses.
pkg/connector/user.go	- Updated userFilter to include additional object classes. - Modified userResource function to classify user accounts based on LDAP attributes. - Added import for slices package.

Possibly related PRs

• Handle case of groups with the same group ID. #61: This PR modifies the List, Grants, and getGroup methods in pkg/connector/group.go, which is directly related to the changes made in the main PR that also affects the pkg/connector/group.go file, specifically in the handling of group-related logic.
• Set user login and aliases. Set all single-valued ldap attributes on user profile. #62: Although this PR primarily focuses on user handling in pkg/connector/user.go, it shares the same file context as the main PR, which may indicate related changes in the overall LDAP handling logic, particularly in how user and group functionalities might interact.

Poem

In the LDAP woods where the groups play,
New filters emerge, brightening the day.
With classes combined, they dance in a line,
While users are sorted, their traits now align.
Hoppy changes abound, in code they reside,
A rabbit's delight, in the logic we bide! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.