Add some better error messages if no credentials json is found or there's an error loading it. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re's an error loading it.
notanthony
reviewed
Mar 14, 2024
| var jsonCredentials []byte | ||
|
|
||
| if cfg.CredentialsJSONFilePath == "" { | ||
| l.Error("no path specified to credentialsJson file") |
There was a problem hiding this comment.
why dont we return an error here?
There was a problem hiding this comment.
Because one day we'll want to get connector capabilities to work without credentials. For now it just errors trying to create the client.
| jsonCredentials, err = os.ReadFile(cfg.CredentialsJSONFilePath) // just pass the file name | ||
| if err != nil { | ||
| l.Error("error reading credentialsJson file", zap.String("CredentialsJSONFilePath", cfg.CredentialsJSONFilePath), zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
can we add the .DS_Store to the gitignore so it doesn't get added back accidentally
notanthony
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.