Auto cli #19
Open
Auto cli #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 24, 2025 23:21
FEAT: Create Account automated FEAT: Sign-in without user BREAK: Email, Secret Key are now required
removed unnecessary return var Added and updated comments
|
Future improvement: add capability to specify custom config directory, service account based authentication |
pquerna
reviewed
Feb 5, 2025
cmd/baton-1password/main.go
Outdated
| l.Error("failed to read user password input: ", zap.Error(err)) | ||
| } | ||
|
|
||
| os.Setenv("BATON_PASSWORD", string(bytePassword)) |
There was a problem hiding this comment.
we should generally pss this by struct and not setenv
There was a problem hiding this comment.
I was doing this to get the terminal entered data to the connector on the second run. Spoke with Bjorn and we decided to remove the terminal interaction altogether.
added 2 commits
February 10, 2025 12:47
FIX: Removed setting unnecessary env variables
Added fields, field depedancy. FEAT: Service Accounts compatibility added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Execution no longer requires manual intervention, provided the necessary info
Bug: Login without 1password app fixed
Add two environment variables and marked them required in order to handle the scenario where no account exists.