feat: generate JS SDK with openapi spec #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshu-dixit
force-pushed
the
ft-generate-js-sdk-with-openapi-spec
branch
from
04addac
to
b737466
Compare
utkarsh-dixit
requested changes
Aug 15, 2024
| @@ -2,9 +2,10 @@ import { OpenAI } from "openai"; | |||
| import { OpenAIToolSet } from "composio-core"; | |||
|
|
|||
| const toolset = new OpenAIToolSet({ | |||
| apiKey: process.env.COMPOSIO_API_KEY, | |||
| apiKey: "cc0fu8lookgq1ov8z4xx9n", | |||
There was a problem hiding this comment.
Need to revert this change
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should not be commited
| @@ -4,7 +4,8 @@ | |||
| "description": "", | |||
| "main": "demo.mjs", | |||
| "scripts": { | |||
| "test": "echo \"Error: no test specified\" && exit 1" | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "debug": "COMPOSIO_API_KEY=cc0fu8lookgq1ov8z4xx9n node sample.mjs" | |||
There was a problem hiding this comment.
Remove COMPOSIO_API_KEY environment variable
| //@ts-ignore | ||
| import { defineConfig } from "@hey-api/openapi-ts"; | ||
|
|
||
| export default defineConfig({ |
There was a problem hiding this comment.
what does this file do and shouldn't it be pointed to staging/prod (with additional support for process.env.BACKEND_URL)
js/src/sdk/models/triggers.ts
Outdated
| @@ -71,8 +76,9 @@ export class Triggers { | |||
| }); | |||
| } | |||
|
|
|||
| async unsubscribe() { | |||
| const clientId = await this.client.getClientId(); | |||
| static async unsubscribe() { | |||
There was a problem hiding this comment.
Need to remove singleton pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.