Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auditd file permission rules to auditing group to fix rule order #12935

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 30, 2025

Description:

Move these auditd file permission rules to auditing group to fix rule order:

  • file_groupownership_audit_binaries
  • file_ownership_audit_binaries
  • file_permissions_audit_binaries
  • file_permissions_etc_audit_auditd
  • file_permissions_etc_audit_rules
  • file_permissions_etc_audit_rulesd

Rationale:

When remediating the whole Ubuntu 24.04 CIS Level 2 profile, these rules were executed before package_audit_installed, resulting in errors due to missing configuration and binary files.

When remediating the whole Ubuntu 24.04 CIS Level 2 profile,
these rules were executed before package_audit_installed,
resulting in errors due to missing configuration and binary files:
 - file_groupownership_audit_binaries
 - file_ownership_audit_binaries
 - file_permissions_audit_binaries
 - file_permissions_etc_audit_auditd
 - file_permissions_etc_audit_rules
 - file_permissions_etc_audit_rulesd

Moving them to the auditing group places them after auditd
is installed, fixing the issue.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 30, 2025
Copy link

openshift-ci bot commented Jan 30, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys requested review from a team January 30, 2025 12:05
@dodys dodys added the enhancement General enhancements to the project. label Jan 30, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 30, 2025
@dodys dodys self-assigned this Jan 30, 2025
Copy link

codeclimate bot commented Jan 30, 2025

Code Climate has analyzed commit 6b431fc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Feb 3, 2025

/packit build

@dodys
Copy link
Contributor

dodys commented Feb 4, 2025

@Mab879 @teacup-on-rockingchair @Xeicker if you could give a look on this PR, it would be nice to include it in the next release.

Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mab879 Mab879 merged commit 5b23fec into ComplianceAsCode:master Feb 4, 2025
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants