Some small patches for SLE15 CIS related remediations #12921
Conversation
…ct with accounts_passwords_pam_tally2
teacup-on-rockingchair
added
Ansible
| {{{ ansible_ensure_pam_module_option('/etc/pam.d/login', 'auth', 'required', 'pam_tally2.so', 'deny', "{{ var_password_pam_tally2 }}", '') }}} | ||
| {{{ ansible_ensure_pam_module_option('/etc/pam.d/login', 'auth', 'required', 'pam_tally2.so', 'even_deny_root', '', '') }}} | ||
| {{{ ansible_ensure_pam_module_option('/etc/pam.d/common-account', 'account', 'required', 'pam_tally2.so', '', '', '') }}} | ||
| {{{ ansible_ensure_pam_module_option('/etc/pam.d/common-account', 'account', 'required', 'pam_tally2.so', '', '', '') }}} |
There was a problem hiding this comment.
File needs new line at end of file
There was a problem hiding this comment.
thx should be fixed in 9e95276 🙇
|
|
||
| - name: Ensure interactive local users are the owners of their respective initialization files | ||
| ansible.builtin.shell: | ||
| cmd: sed -ri 's/(^shadow:[^:]*:[^:]*:)([^:]+$)/\1/' /etc/group |
There was a problem hiding this comment.
File needs new line at end of file
There was a problem hiding this comment.
thx should be fixed in 9e95276 🙇
|
|
||
| - name: Ensure interactive local users are the owners of their respective initialization files | ||
| ansible.builtin.shell: | ||
| cmd: sed -ri 's/(^shadow:[^:]*:[^:]*:)([^:]+$)/\1/' /etc/group |
There was a problem hiding this comment.
You might be able to do this with lineinfile vs shell and that would be preferred.
There was a problem hiding this comment.
thx should be fixed in 9e95276 🙇
- fix EOF warngins - replace executing of bash command from ansible with more standard approach using lineinfile Thanks to @Mab879 for the notes 🙇
|
Code Climate has analyzed commit bfcec76 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
Rationale: