-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning to AutoMatus #10394
Add a warning to AutoMatus #10394
Conversation
I will not modify the amount of _check_rule_scenario parameters because I didn't change nor introduce its definition. |
06b3498
to
a8f42b9
Compare
I have rebased this PR on the top of the latest upstream master branch. |
This is a good addition although in my opinion we should in future PRs slowly get away from the |
I fully agree. Do you want some changes related to this in this PR? |
There is a fail in the Testing farm CentOS stream 8 job:
But, it's in the |
This adds a warning that prevents a confusion in situation when a test scenario has a profile in its header but the rule isn't a part of that profile but is present in the built data stream. For more context, see: ComplianceAsCode#10369
a8f42b9
to
bbbc85f
Compare
I have rebased this PR on the top of the latest upstream master branch. |
Not necessarily, I would prefer a separate PR for that. |
Code Climate has analyzed commit bbbc85f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (0.0% change). View more on Code Climate. |
Great! |
@ggbecker , are you ok assigning this PR for you and reviewing it? |
This adds a warning that prevents a confusion in situation when a test scenario has a profile in its header but the rule isn't a part of that profile but is present in the built data stream.
For more context, see:
#10369
Rationale:
This can save a lot of time when investigating errors in Automatus output.
Review Hints:
python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 --scenario selinux_enforcing.pass.sh selinux_state
python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 --scenario no_line.fail.sh sshd_rekey_limit