Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure users do not use the CPU mirror for non-CPU installs #871

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Ensure users do not use the CPU mirror for non-CPU installs #871

merged 4 commits into from
Feb 8, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 8, 2025 •
edited by sync-by-unito bot
Loading

  • Resolves cannot start app after uv command fails - empty index URL
  • Silently corrects use of default python mirror to default mirror for selected device
  • Resolves issue where user is unable to start the app due to an invalid mirror configuration

The mirror correction is a workaround that should be expanded into a proper feature, or removed.

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner February 8, 2025 21:53
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 8, 2025
@webfiltered webfiltered enabled auto-merge (squash) February 8, 2025 21:53
@dosubot dosubot bot added the bug Something isn't working label Feb 8, 2025
@webfiltered webfiltered mentioned this pull request Feb 8, 2025
Open
robinjhuang
robinjhuang reviewed Feb 8, 2025
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
@webfiltered webfiltered merged commit a880481 into main Feb 8, 2025
7 checks passed
@webfiltered webfiltered deleted the ensure-valid-mirrors branch February 8, 2025 22:35
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjhuang robinjhuang robinjhuang approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @robinjhuang