Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual env won't load on linux #866

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Fix virtual env won't load on linux #866

merged 5 commits into from
Feb 9, 2025

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Feb 8, 2025

Various environment variables can interfere with the install process, including modifications to PATH made by python version managers (inserting shims). Bypassing shell profiles alone is not enough because environment variables will already be set in the parent process and inherited.

linux-desktop.mp4

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner February 8, 2025 06:43
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Feb 8, 2025
@christian-byrne christian-byrne requested a review from a team as a code owner February 8, 2025 06:54
@christian-byrne christian-byrne marked this pull request as draft February 8, 2025 07:06
@christian-byrne christian-byrne marked this pull request as ready for review February 8, 2025 07:15
@christian-byrne
Copy link
Contributor Author

christian-byrne commented Feb 9, 2025

I've removed the args that reset the environment, as it's difficult right now to test all the consequences. For now, just perform the bash equivalent of fix introduced in:

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2025
@webfiltered webfiltered merged commit 5f46874 into main Feb 9, 2025
7 checks passed
@webfiltered webfiltered deleted the fix-linux-install branch February 9, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants