Upgrade to use patternlab core 3.x

[mbulfair]

Upgrade the edition to support https://github.com/pattern-lab/patternlab-node/releases latest release.

Which includes pattern-lab/patternlab-node#745

[bmuenzenmeyer]

Should also include pattern-lab/patternlab-node#745

[renestalder]

Wouldn't it be better to separate the upgrade to Webpack 4 to a separate task? Sure these are both breaking changes but still, in case one or the other gets stuck, you're still open to create a release independently.

Also, I think I could more easily contribute to the Webpack part if needed, but not to the patternlab core one.

[mbulfair]

@renestalder Thank you, I've split it up, #16 is dedicated to that work. This is a great suggestion thank you. The more contributors the better.

[Josh68]

First off, I might agree with @renestalder's suggestion.

That said ;) ...

If you are interested, I took a stab at a fork with PL v3 and Webpack v4, but it's rough around the edges. I can say it runs and builds a project I've been working on separately using the release version of patternlab-edition-node-webpack. I'd be interested to get your input, or just have a look at it if you're interested.

A few notes

• It seems that postinstall doesn't work as it did previously, so I commented the call to it from your install script. Not sure how to address this issue for managing plugins automatically.
• See webpack.config.babel.js around line 136. compilation.fileDependencies is now a JS Set instead of an Array, and I'm not sure if this the the best way to insert paths from the config. As I said, my project compiles, but I'm getting lots of warnings about files not being found, plus an unhelpful dump when I kill the process during development that suggests to me that file paths may be at issue, since the Set is an object-like iterable with entries that are not file paths (unlike with a plain array).

[mbulfair]

Thank you @Josh68 I will take a look as soon as I can.

[Josh68]

FWIW, I think my fork is not a good reference. I've been re-reading the upgrade docs for PL v3, and I'm now trying to wrap my head around what Webpack will handle, and how, and it's substantially different with v3 than with v2.

My own goal is to have the ability to use loaders, primarily for SASS/Postcss, and plugins. but with PL core handling file copying and potentially dev serving and watching, I've kind of lost a grasp on how to configure Webpack to do a more minimal set of tasks, at the right time and in the right order.

Would it make sense to define goals for a v3 conversion?

[mbulfair]

Let's connect on gitter @Josh68

[mbulfair]

Now with upgrading of Webpack to version 4, this prepares this edition to work better with the core 3.x release.