final countries pages without bonus #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 21, 2024
| @@ -212,14 +211,32 @@ | |||
| .countries-grid .country-info { | |||
| position: relative; | |||
| padding: 30px 25px; | |||
| background-color: white; | |||
| box-shadow: 0 2px 15px rgba(0, 0, 0, 0.08); | |||
There was a problem hiding this comment.
You will want to save your colors into a css variables
| const getDetailsOfCountry = () => { | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| const countryDetails = JSON.parse(localStorage.getItem("countryDetails")); | ||
|
|
There was a problem hiding this comment.
Same concepts should be extracted into a service so you wont repeat your logic again and again
details.js
Outdated
| if (countryDetails) { | ||
| console.log("Country Details on details.html:", countryDetails); | ||
| document.querySelector(".main-country-flag").innerHTML = `<img class="country-flag" src="${countryDetails.flag}" alt="${countryDetails.name} flag" />`; | ||
| document.querySelector(".country-name").innerHTML = `${countryDetails.name}`; |
There was a problem hiding this comment.
Do not use innerHTML it is a dangerous method.
|
|
||
|
|
||
| const darkMode = () => { | ||
| const lightBody = document.querySelector('.body'); |
There was a problem hiding this comment.
If dark mode is a name of a function, you should give it more meaningful name.
When I read darkMode it does not looks like a function name to me. more like a variable
index.js
Outdated
| if (chosenRegion == 'america') { | ||
| filteredCountries = filteredCountries.filter(country => country.region === 'Americas'); | ||
| } | ||
| if (chosenRegion == 'asia') { |
There was a problem hiding this comment.
This code repeat itself, you can do something like this :
const regionMap: Record<string, string> = {
america: 'Americas',
asia: 'Asia'
};
if (chosenRegion in regionMap) {
filteredCountries = filteredCountries.filter(country => country.region === regionMap[chosenRegion]);
}In this way you will not repeat yourself again and again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.