added js #18
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| const themeToggleButton = document.getElementById("theme-toggle"); | ||
|
|
||
| const changeBackgroundColor = () => { | ||
| // Toggle the 'Dark' class on the <body> | ||
| document.body.classList.toggle('Dark'); | ||
|
There was a problem hiding this comment. In here please use styling via css classes and not js (this way you don`t need all of your logic) |
||
|
|
||
| if (document.body.classList.contains('Dark')) { | ||
| themeToggleButton.querySelector('.theme-text').textContent = 'Light Mode'; | ||
| document.body.style.backgroundColor = 'hsl(207, 26%, 17%)'; | ||
| document.querySelector('header').style.backgroundColor = 'hsl(209, 23%, 22%)'; // Dark header | ||
| document.querySelector('header').style.color = 'white'; // Light text color | ||
| } else { | ||
| themeToggleButton.querySelector('.theme-text').textContent = 'Dark Mode'; | ||
| document.body.style.backgroundColor = 'white'; // Light background | ||
| document.querySelector('header').style.backgroundColor = 'white'; // Light header | ||
| document.querySelector('header').style.color = 'black'; // Dark text color | ||
| } | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| const countryDetailsSection = document.querySelector(".country-details"); | ||
| const loader = document.querySelector(".loader"); | ||
|
|
||
| // Extract country name | ||
| const urlParams = new URLSearchParams(window.location.search); | ||
| const countryName = urlParams.get("country"); | ||
|
|
||
|
There was a problem hiding this comment. You dont need to add this comment, you already have a variable names |
||
| if (!countryName) { | ||
| countryDetailsSection.innerHTML = `<p>Country not specified in the query.</p>`; | ||
| loader.style.display = "none"; | ||
| return; | ||
| } | ||
|
|
||
| fetch("./CountriesData.json") | ||
| .then((response) => response.json()) | ||
|
There was a problem hiding this comment. Hardcoded strigns should be saved into constants variables |
||
| .then((data) => { | ||
| const country = data.find((c) => c.name === countryName); | ||
|
|
||
| if (!country) { | ||
| countryDetailsSection.innerHTML = `<p>Country details not found.</p>`; | ||
| return; | ||
|
There was a problem hiding this comment. Please do not use |
||
| } | ||
|
|
||
| countryDetailsSection.innerHTML = ` | ||
| <div class="country-details"> | ||
|
|
||
| <div class="country-flag"> | ||
| <img src="${country.flag}" alt="${country.name} Flag" /> | ||
| </div> | ||
| <div class="country-info"> | ||
| <h2>${country.name}</h2> | ||
| <ul> | ||
| <li><strong>Population:</strong> ${country.population.toLocaleString()}</li> | ||
| <li><strong>Region:</strong> ${country.region}</li> | ||
| <li><strong>Capital:</strong> ${country.capital}</li> | ||
| </ul> | ||
| </div> | ||
| </div>`; | ||
| }) | ||
|
|
||
| loader.style.display = "none"; | ||
| }); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| const countriesGrid = document.querySelector(".countries-grid"); | ||
| const searchInput = document.querySelector(".search-input"); | ||
| const dropdownHeader = document.querySelector(".dropdown-header"); | ||
| const dropdownBody = document.querySelector(".dropdown-body"); | ||
| const dropdownItems = document.querySelectorAll(".dropdown-body ul li"); | ||
|
|
||
| // Fetch data from CountriesData.json | ||
| fetch("./CountriesData.json") | ||
| .then((response) => response.json()) | ||
|
There was a problem hiding this comment. Why not extract his into a function and call if |
||
| .then((data) => { | ||
| renderCountries(data); | ||
| setupFilters(data); | ||
| }); | ||
|
|
||
| // Function to render countries | ||
| const renderCountries = (data) => { | ||
| countriesGrid.innerHTML = ""; | ||
|
There was a problem hiding this comment. The name of the function should indicate what it is doing |
||
| data.forEach((country) => { | ||
| countriesGrid.innerHTML += ` | ||
| <a href="#" class="country scale-effect" data-country-name="${country.name}" data-region="${country.region.toLowerCase()}" onclick="setupCountryLinks(event)"> | ||
| <div class="country-flag"> | ||
| <img src="${country.flag}" alt="${country.name} Flag" /> | ||
| </div> | ||
| <div class="country-info"> | ||
| <h2 class="country-title">${country.name}</h2> | ||
| <ul class="country-brief"> | ||
| <li><strong>Population: </strong>${country.population.toLocaleString()}</li> | ||
| <li><strong>Region: </strong>${country.region}</li> | ||
| <li><strong>Capital: </strong>${country.capital}</li> | ||
| </ul> | ||
| </div> | ||
| </a>`; | ||
| }); | ||
| }; | ||
|
|
||
|
|
||
| const setupCountryLinks = (event) => { | ||
|
|
||
| event.preventDefault(); // Prevent default anchor behavior | ||
| const countryName = event.currentTarget.getAttribute("data-country-name"); | ||
| window.location.href = `details.html?country=${encodeURIComponent(countryName)}`; | ||
| }; | ||
|
|
||
|
|
||
|
|
||
| const openOptions = () => { | ||
| const dropdownWrapper = document.querySelector('.dropdown-wrapper'); | ||
| dropdownWrapper.classList.toggle('open'); | ||
| }; | ||
|
|
||
|
|
||
|
|
||
| // Set up search and region filters | ||
| const setupFilters = (data) => { | ||
|
|
||
| searchInput.addEventListener("input", (e) => { | ||
| const query = e.target.value.toLowerCase(); | ||
| const filteredData = data.filter((country) => | ||
| country.name.toLowerCase().includes(query) | ||
| ); | ||
| renderCountries(filteredData); | ||
| }); | ||
|
|
||
|
|
||
| // Dropdown filter | ||
| dropdownItems.forEach((item) => { | ||
| item.addEventListener("click", () => { | ||
| const region = item.getAttribute("data-region"); | ||
| const filteredData = | ||
| region === "all" | ||
| ? data | ||
| : data.filter((country) => country.region.toLowerCase() === region); | ||
| renderCountries(filteredData); | ||
|
|
||
| // Close dropdown after selection | ||
| dropdownBody.classList.remove("visible"); | ||
| }); | ||
| }); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already have class of container, why do you need also id ?