feat: to_other_language cirq without QASM2.0 #119

JulienCalistoTD · 2024-12-05T16:37:55Z

No description provided.

hJaffaliColibritd

Only reviewed circuit.py

mpqp/core/circuit.py

hJaffaliColibritd · 2024-12-06T10:23:06Z

mpqp/core/circuit.py

+                        controls.append(cirq_qubits[control])
+                    cirq_instruction = instruction.to_other_language(Language.CIRQ)
+                    cirq_circuit.append(cirq_instruction.on(*controls, *targets))
+                else:


Here we handle all the other cases ? (Parametrized gate, Barrier, BasisMeasure, ..) right ?

Cirq doesn't have a Barrier operation, so we skips it. breakpoints is also skip. While the rest is handled properly.

Ok, even BasisMeasure ?

The BasisMeasure is a simple measurement with a pre-measurement circuit, we juste have to concatenate it. so yes

Do we concatenate this pre-measurement circuit (the one related with the basis change I suppose) somewhere? (because I checked the code, and I didn't found it).

But I ask myself if we should include that change of basis or not. I am not convinced personally, but if we do we have to warn the user. I would export the circuit without the change of basis additional unitary. What do you think ?

mpqp/core/instruction/gates/native_gates.py

mpqp/execution/providers/google.py

Henri-ColibrITD

minor questions

hJaffaliColibritd · 2024-12-24T14:13:21Z

mpqp/core/circuit.py

+                        controls.append(cirq_qubits[control])
+                    cirq_instruction = instruction.to_other_language(Language.CIRQ)
+                    cirq_circuit.append(cirq_instruction.on(*controls, *targets))
+                else:


Ok, even BasisMeasure ?

hJaffaliColibritd · 2024-12-26T16:06:12Z

mpqp/core/instruction/gates/native_gates.py

+
+        return lambda theta: CirqControlledGate(ZPowGate(exponent=theta / np.pi))
+
+        return controlled_phase


This line is useless right ?

done: removed

hJaffaliColibritd · 2024-12-26T16:09:00Z

mpqp/core/instruction/gates/native_gates.py

+        from cirq.ops.global_phase_op import GlobalPhaseGate
+        from cirq.ops.raw_types import Qid
+
+        class CirqUGate(QasmUGate):  # pyright: ignore[reportUntypedBaseClass]


The class will be redifined each time we call the property. Isn't it better if we define the class outside and only return it when needed ?

No, because there are many import requirements and we only want to import them if we use this function.

Ok, I think we can find another way, but can keep it like this for the moment and add a 3M-TODO to improve this. You can resolve this conversation yourself once the todo is added.

hJaffaliColibritd · 2024-12-26T16:12:09Z

mpqp/core/instruction/gates/native_gates.py

+            def __repr__(self) -> str:
+                return (
+                    f'U('
+                    f'theta={self.theta !r}, '


Why !r is used for theta and hi, and not for lambda ?

Another question concerning those angles, no need to tweak them with some division by pi ? When you can ry and rz in the decompose ?

because it is an end of line so does not need to be added at the end. No we don't need to tweak the angle.

mpqp/core/instruction/gates/native_gates.py

hJaffaliColibritd · 2024-12-26T16:15:42Z

mpqp/core/instruction/gates/native_gates.py

+    def cirq_gate(cls):
+        from cirq.ops.common_gates import ZPowGate
+
+        return lambda theta: ZPowGate(exponent=theta / np.pi)


Same question as for Rk

Same answer as for Rk

hJaffaliColibritd · 2024-12-26T16:16:10Z

mpqp/core/instruction/gates/native_gates.py

+        from cirq.ops.controlled_gate import ControlledGate as CirqControlledGate
+        from cirq.ops.common_gates import ZPowGate
+
+        return lambda theta: CirqControlledGate(ZPowGate(exponent=theta / np.pi))


Same question as for Rk

Same answer as for Rk

hJaffaliColibritd · 2024-12-26T16:21:13Z

mpqp/tools/maths.py

@@ -161,7 +161,7 @@ def closest_unitary(matrix: Matrix):


 @typechecked
-def cos(angle: Expr | Real) -> sp.Expr | float:
+def cos(angle: Expr | Real | float) -> sp.Expr | float:


In principle, no need to add float here, as it is "contained" in Real

yes, but i had typcheck issues

so at the end Real from the package number worked no ? This join the same discussion as Complex from numbers

hJaffaliColibritd · 2024-12-26T16:21:21Z

mpqp/tools/maths.py

@@ -186,7 +186,7 @@ def cos(angle: Expr | Real) -> sp.Expr | float:


 @typechecked
-def sin(angle: Expr | Real) -> sp.Expr | float:
+def sin(angle: Expr | Real | float) -> sp.Expr | float:


same as above

hJaffaliColibritd · 2024-12-26T16:21:47Z

mpqp/tools/maths.py

@@ -211,7 +211,7 @@ def sin(angle: Expr | Real) -> sp.Expr | float:


 @typechecked
-def exp(angle: Expr | Complex) -> sp.Expr | complex:
+def exp(angle: Expr | Complex | complex) -> sp.Expr | complex:


Same remark for complex and Complex

same as above

this worked at the end right ?

hJaffaliColibritd · 2025-01-31T10:36:23Z

mpqp/core/circuit.py

+                        controls.append(cirq_qubits[control])
+                    cirq_instruction = instruction.to_other_language(Language.CIRQ)
+                    cirq_circuit.append(cirq_instruction.on(*controls, *targets))
+                else:


Do we concatenate this pre-measurement circuit (the one related with the basis change I suppose) somewhere? (because I checked the code, and I didn't found it).

But I ask myself if we should include that change of basis or not. I am not convinced personally, but if we do we have to warn the user. I would export the circuit without the change of basis additional unitary. What do you think ?

mpqp/core/instruction/gates/native_gates.py

hJaffaliColibritd · 2025-01-31T10:38:26Z

mpqp/core/instruction/gates/native_gates.py

+        from cirq.ops.global_phase_op import GlobalPhaseGate
+        from cirq.ops.raw_types import Qid
+
+        class CirqUGate(QasmUGate):  # pyright: ignore[reportUntypedBaseClass]


Ok, I think we can find another way, but can keep it like this for the moment and add a 3M-TODO to improve this. You can resolve this conversation yourself once the todo is added.

mpqp/core/instruction/gates/native_gates.py

mpqp/execution/providers/google.py

hJaffaliColibritd · 2025-01-31T11:02:14Z

mpqp/tools/maths.py

@@ -161,7 +161,7 @@ def closest_unitary(matrix: Matrix):


 @typechecked
-def cos(angle: Expr | Real) -> sp.Expr | float:
+def cos(angle: Expr | Real | float) -> sp.Expr | float:


so at the end Real from the package number worked no ? This join the same discussion as Complex from numbers

hJaffaliColibritd · 2025-01-31T11:02:26Z

mpqp/tools/maths.py

@@ -211,7 +211,7 @@ def sin(angle: Expr | Real) -> sp.Expr | float:


 @typechecked
-def exp(angle: Expr | Complex) -> sp.Expr | complex:
+def exp(angle: Expr | Complex | complex) -> sp.Expr | complex:


this worked at the end right ?

feat: to_other_language cirq without QASM2.0

64a75ae

hJaffaliColibritd requested review from hJaffaliColibritd and Henri-ColibrITD December 6, 2024 10:12

hJaffaliColibritd reviewed Dec 6, 2024

View reviewed changes

Henri-ColibrITD reviewed Dec 16, 2024

View reviewed changes

mpqp/core/instruction/gates/native_gates.py Show resolved Hide resolved

Henri-ColibrITD reviewed Dec 16, 2024

View reviewed changes

mpqp/execution/providers/google.py Show resolved Hide resolved

Henri-ColibrITD requested changes Dec 16, 2024

View reviewed changes

fix: handle barrier, breakpoint

b90e4c8

hJaffaliColibritd requested review from hJaffaliColibritd and Henri-ColibrITD December 18, 2024 13:03

hJaffaliColibritd requested changes Dec 26, 2024

View reviewed changes

Henri-ColibrITD approved these changes Jan 2, 2025

View reviewed changes

chore: clean up

910ae08

JulienCalistoTD requested a review from hJaffaliColibritd January 15, 2025 11:00

hJaffaliColibritd requested changes Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: to_other_language cirq without QASM2.0 #119

feat: to_other_language cirq without QASM2.0 #119

JulienCalistoTD commented Dec 5, 2024

hJaffaliColibritd left a comment

hJaffaliColibritd Dec 6, 2024

JulienCalistoTD Dec 17, 2024

hJaffaliColibritd Dec 24, 2024

JulienCalistoTD Dec 27, 2024

hJaffaliColibritd Jan 31, 2025

Henri-ColibrITD left a comment

hJaffaliColibritd Dec 24, 2024

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025 •

edited

Loading

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025 •

edited

Loading

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Dec 27, 2024

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025

hJaffaliColibritd Dec 26, 2024

JulienCalistoTD Jan 15, 2025

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Jan 31, 2025

hJaffaliColibritd Jan 31, 2025


		return lambda theta: CirqControlledGate(ZPowGate(exponent=theta / np.pi))

		return controlled_phase

feat: to_other_language cirq without QASM2.0 #119

Are you sure you want to change the base?

feat: to_other_language cirq without QASM2.0 #119

Conversation

JulienCalistoTD commented Dec 5, 2024

hJaffaliColibritd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Henri-ColibrITD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JulienCalistoTD Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JulienCalistoTD Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JulienCalistoTD Jan 15, 2025 •

edited

Loading

JulienCalistoTD Jan 15, 2025 •

edited

Loading