Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data_manager.instance_name() public API #6146

Merged
merged 1 commit into from
May 12, 2023
Merged

Add data_manager.instance_name() public API #6146

merged 1 commit into from
May 12, 2023

Conversation

Jackenmen
Copy link
Member

Description of the changes

Adds a new data_manager.instance_name() public API to replace the instance_name variable that was privatized in 3.5.0. This has been split out from #6023.

Have the changes in this PR been tested?

No

@Jackenmen Jackenmen added the Type: Feature New feature or request. label May 11, 2023
@Jackenmen Jackenmen added this to the 3.5.2 milestone May 11, 2023
@github-actions github-actions bot added Category: Cogs - Audio This is related to the Audio cog. Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. labels May 11, 2023
@flaree flaree merged commit 2369017 into Cog-Creators:V3/develop May 12, 2023
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label May 12, 2023
@Jackenmen Jackenmen deleted the add_instance_name_api branch May 12, 2023 11:03
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels May 14, 2023
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
@Jackenmen @Dav-Git
Add data_manager.instance_name() public API (Cog-Creators#6146)
91b1fe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaree flaree flaree approved these changes

@aikaterna aikaterna Awaiting requested review from aikaterna aikaterna is a code owner

@PredaaA PredaaA Awaiting requested review from PredaaA PredaaA is a code owner

Assignees
No one assigned
Labels
Category: Cogs - Audio This is related to the Audio cog. Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackenmen @flaree