Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neve FSE child theme #109

Closed
irinelenache opened this issue Jan 29, 2024 · 9 comments
Closed

Neve FSE child theme #109

irinelenache opened this issue Jan 29, 2024 · 9 comments
Labels
customer report Indicates the request came from a customer. doc-needed This issue requires documentation updates or additions once it has been completed. new feature Request for a new feature or functionality to be added to the project.
Milestone

Comments

@irinelenache
Copy link
Contributor

What problem does this address?

There are users who want to use a child theme with Neve FSE (and other FSE themes) in order to make some personal customizations, and we can offer only guides on how to achieve this.

Reported here - https://wordpress.org/support/topic/child-theme-problem-33/#post-17380947 (1 star review)

What is your proposed solution?

It would be great to have a ready-to-use child theme as we have for Neve or Hestia.

Will this feature require documentation? (Optional)

Yes, it requires documentation.

@irinelenache irinelenache added new feature Request for a new feature or functionality to be added to the project. customer report Indicates the request came from a customer. labels Jan 29, 2024
@pirate-bot pirate-bot added the doc-needed This issue requires documentation updates or additions once it has been completed. label Jan 29, 2024
@JohnPixle
Copy link
Contributor

Thanks Irinel!

We can do that if it is possible and easy, not short of any technicalities here. If it is easy, we can schedule for the upcoming release. @HardeepAsrani thoughts?

@JohnPixle JohnPixle added this to the 1.0.7 milestone Jan 30, 2024
@irinelenache
Copy link
Contributor Author

Thank you for checking @JohnPixle!

As a note here, the child themes are pretty often asked for in the support forums for all our FSE themes. If indeed it's easy work, it would be great if we could do the same at least for Raft also.

@JohnPixle
Copy link
Contributor

@irinelenache I have the same thinking as well, yes. I remember some discussions in the past about fse child themes, so I am waiting for @HardeepAsrani to confirm it's doable and easy, and I will schedule for other themes as well 👍🏻

@HardeepAsrani
Copy link
Member

Hey @irinelenache,

I've attached the child theme here. You can upload it wherever we have these, or let me know and I can do it.

Personally, I don't think you really need a child theme for FSE themes as all the information can really be changed from the Site Editor but if the user wants it then why not. If we want to make one for raft, we just need to replace all the instance where we use neve-fse or neve_fse in this file with raft.

It's just two files with about 10 lines of text.

neve-fse-child.zip

@JohnPixle
Copy link
Contributor

JohnPixle commented Feb 6, 2024

@HardeepAsrani Thanks for the help here.

I believe we can upload the child theme files and instructions in the docs, right?

I followed the same approach you suggested and created the zips for the other child themes as well.

Raft_child.zip
fork_child.zip
riverbank_child.zip
jaxon_child.zip

But have a couple of issues / suggestions:

1. Incompatible archive error
Apart from Neve FSE, the other child themes show this error.

Screenshot 2024-02-06 at 10 44 53 AM

2. Secondly, would it be possible to include the theme screenshot for the child themes?
Screenshot 2024-02-06 at 10 46 37 AM

@HardeepAsrani Can you take a look on the above? I am not sure what is causing the error. I have a test environment for you:

 Admin area URL: https://specialtexture.s4-tastewp.com/wp-admin 
 Username: pixle 
 Password: dCZEmCplhDU 

In my opinion it does not hurt to have them available, just in case anyone wants to use them.

How we proceed from here @irinelenache ? Can you guys create the related docs ? Otherwise we can do it as well, as soon as we fix the issues above.

Let me know!
Thanks

@HardeepAsrani
Copy link
Member

@JohnPixle It seems to be an issue with WP/MacOS: https://diviextended.com/incompatible-archive-error-in-wordpress/

For images, I suppose we can just include the same image as the screenshot of the parent theme?

@HardeepAsrani
Copy link
Member

Apart from the zip issue, child themes look to be coded properly.

@JohnPixle
Copy link
Contributor

For images, I suppose we can just include the same image as the screenshot of the parent theme?

@HardeepAsrani yes it is fine, do you mind mind taking care of this? or tell my what I should add to the file?

And how are we going to address the zip issue? Have the files zipped on a PC? 😛

@HardeepAsrani
Copy link
Member

@JohnPixle I did that but it seems Block Themes aren't 100% compatible with child themes. If you create a child theme for a block theme, some templates like Header/Footer are missing on the homepage as Block Editor still uses active theme slug for looking and doesn't fallback to parent theme when a child theme is active. For now, I'll recommend when don't ship child themes and ask users to use Site Editor for making changes.

@selul selul closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer report Indicates the request came from a customer. doc-needed This issue requires documentation updates or additions once it has been completed. new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
Development

No branches or pull requests

5 participants