Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDC Tools sprints 3 and 4 #1276

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

SDC Tools sprints 3 and 4 #1276

wants to merge 31 commits into from

Conversation

illicitonion
Copy link
Member

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/679b6b44cb58380009caa92f
😎 Deploy Preview https://deploy-preview-1276--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/679b6b440e36590008beeade
😎 Deploy Preview https://deploy-preview-1276--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/679b6b44dd270600082ddabf
😎 Deploy Preview https://deploy-preview-1276--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/679b6b446236a80008752719
😎 Deploy Preview https://deploy-preview-1276--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/679b6b44523fcb00084690cf
😎 Deploy Preview https://deploy-preview-1276--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 70 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/679b6b4460ddc90008b56eab

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/679b6b446236a8000875271b
😎 Deploy Preview https://deploy-preview-1276--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 70abc83
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/679b6b44de74060008f466e1
😎 Deploy Preview https://deploy-preview-1276--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrath SallyMcGrath added this to the SDC-MAR-25 Launch milestone Jan 7, 2025
SallyMcGrath
SallyMcGrath requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny notes. Loving it. So happy to see cowsay hee.

common-content/en/module/tools/comparing-javascript-and-python/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/comparing-javascript-and-python/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/comparing-javascript-and-python/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/comparing-javascript-and-python/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/comparing-javascript-and-python/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/using-python-dependencies/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/using-python-dependencies/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/virtual-environments/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/virtual-environments/index.md Show resolved Hide resolved
common-content/en/module/tools/virtual-environments/index.md Show resolved Hide resolved
40thieves
40thieves reviewed Jan 26, 2025
View reviewed changes
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got through Sprint 3 so far, but it's looking good.

common-content/en/module/tools/nodejs/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/first-nodejs-program/index.md

This is an example of the same language features (`import`) being used slightly differently (the `"node:"` is a special prefix to say "specially from node").

The `process` module is built into NodeJS for managing our process. We can use it to find out what arguments were passed to the process when it started, find out what user ran the process, exit the process, and more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth tooltip-ing "process" here as a reminder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, but I'm struggling to come up with a useful wording for that tooltip... Got any suggestions?

common-content/en/module/tools/first-nodejs-program/index.md Show resolved Hide resolved
common-content/en/module/tools/first-nodejs-program/index.md Show resolved Hide resolved
common-content/en/module/tools/first-nodejs-program/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/using-npm-dependencies/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/installing-npm-dependencies/index.md Show resolved Hide resolved
common-content/en/module/tools/first-nodejs-program/index.md Outdated Show resolved Hide resolved
common-content/en/module/tools/installing-npm-dependencies/index.md Show resolved Hide resolved
common-content/en/module/tools/read-about-operating-systems/index.md Outdated Show resolved Hide resolved
illicitonion and others added 16 commits January 27, 2025 16:05
@illicitonion
SDC Tools sprints 3 and 4
9751f76
@illicitonion
Add module success criteria
e16d252
@illicitonion
Simplify themes
a5c60c6
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
3a37c85 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
706d7a2 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
beffbc7 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
9f63e52 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
964da99 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/comparing-javascript-and-python…
6f09666 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/converted-program/index.md
165b2d6 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/converted-program/index.md
bd744cb 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/converting-javascript-to-python…
d59e0ac 
…/index.md

Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/counting-words/index.md
8670f27 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/first-nodejs-program/index.md
83b06ba 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/first-nodejs-program/index.md
ffbf68c 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion @SallyMcGrath
Update common-content/en/module/tools/single-use-data-analysis/index.md
246882f 
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
@illicitonion illicitonion force-pushed the sdc-tools-sprint3and4 branch from edee0a9 to ee3ede4 Compare January 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@40thieves 40thieves 40thieves left review comments

@SallyMcGrath SallyMcGrath SallyMcGrath requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Curriculum Planning
Status: 🔖 Ready
Milestone
SDC-MAR-25 Launch
Development

Successfully merging this pull request may close these issues.
3 participants
@illicitonion @40thieves @SallyMcGrath