-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions Base #1274
Merged
Merged
Extensions Base #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com> # Conflicts: # CodeEdit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com> # Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # CodeEdit/Features/InspectorSidebar/InspectorSidebarToolbarTop.swift # CodeEdit/Features/InspectorSidebar/InspectorSidebarView.swift
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
6 tasks
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Wouter01
requested review from
austincondiff,
matthijseikelenboom and
lukepistrol
May 25, 2023 18:11
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
CodeEdit/Features/StatusBar/Views/StatusBarDrawer/StatusBarDrawer.swift
Outdated
Show resolved
Hide resolved
0xWDG
reviewed
May 26, 2023
CodeEdit/Features/StatusBar/Views/StatusBarDrawer/StatusBarDrawer.swift
Outdated
Show resolved
Hide resolved
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
0xWDG
reviewed
May 26, 2023
CodeEdit/Features/StatusBar/ViewModels/StatusBarViewModel.swift
Outdated
Show resolved
Hide resolved
0xWDG
reviewed
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya,
Sorry for the slight delay, it's a big PR.
It looks good to me, there are some points i want to address:
- I suggested on some comments to add
TODO:
to make them more recognizable. - I'm wondering about some commented out code, will this ever be used again, or are they obsolete
- 1 suggestion for an
swiftlint:disable
rule.
Great work!
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
0xWDG
previously approved these changes
May 27, 2023
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
Signed-off-by: Wouter01 <wouterhennen@gmail.com> # Conflicts: # CodeEdit/CodeEditApp.swift
Signed-off-by: Wouter01 <wouterhennen@gmail.com>
0xWDG
approved these changes
May 29, 2023
matthijseikelenboom
approved these changes
May 29, 2023
austincondiff
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a start of the integration of ExtensionKit into the main app. It adds the following things:
Additionally, some changes were made to make things work:
See CodeEditApp/CodeEditKit#14 for CodeEditKit API
An example extension app (already compiled) and project can be found here:
ExampleExtension.zip
Related Issues
Checklist
Screenshots