Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates, refactoring, version() call #87

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sashee
Copy link

@sashee sashee commented Mar 12, 2021

This PR does multiple things:

  • update dependencies and add the package-lock.json (it should be committed to the repository)
  • add the missing tslib dependency
  • refactor tmpdir handling to be more cross-platform (uses the platform's tempdir) and safer (removed the tmps variable and the sync delete call)
  • add a version() call that runs pdftocairo -v and prints the results

According to the tests and my experience these changes don't break existing functionality

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #87 (27b128e) into master (9e35c6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          103       104    +1     
  Branches        48        49    +1     
=========================================
+ Hits           103       104    +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e35c6d...a38b8c1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant