feat: send RunPart metadata to upload endpoint
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fargito
commented
Jan 15, 2025
fargito
commented
- chore(rust): bump toolchain from 1.79.0 to 1.84.0
- chore: add missing spellings
- feat: add platform_slug to upload metadata
- feat: add platform_run_part to providers
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
20 times, most recently
from
06848b2 to
9b963a3
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
8 times, most recently
from
fb53a4f to
dfdd096
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
4 times, most recently
from
25cd578 to
f87e92e
Compare
|
@adriencaccia ready for a first review |
adriencaccia
requested changes
Jan 28, 2025
art049
requested changes
Jan 29, 2025
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
f87e92e to
d89c070
Compare
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
7490e74 to
702328e
Compare
|
@adriencaccia @Arthur I updated and also added some tests |
fargito
force-pushed
the
cod-447-compute-run-and-runpart-identifiers-and-metadata-in-the
branch
from
702328e to
ed81950
Compare
|
@art049 sorry about the force-pushes. Here is the comparison link between the reviewed and the latest version: https://github.com/CodSpeedHQ/runner/compare/f87e92ed46b24c5635282521365023e1a31571d5..ed81950a62afe82f0c8d2839fa940d46ea9bc5a3 |
adriencaccia
approved these changes
Jan 30, 2025
art049
reviewed
Jan 31, 2025
art049
approved these changes
Jan 31, 2025
|
@adriencaccia I removed some values from the metadata, can you release a new beta version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.