Allow configuring CDN requests max concurrency to reduce flakiness #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santam85 FYI you might encounter similar issue depending on your setup when using Artifactory CDN if your local repository is containing large amount of indexed specs. |
segiddins
approved these changes
Aug 6, 2024
maikelvdh
force-pushed
the
cdn-concurrency
branch
from
beec95a
to
95152b0
Compare
maikelvdh
force-pushed
the
cdn-concurrency
branch
from
95152b0
to
ec7ef6f
Compare
maikelvdh
changed the title
|
@segiddins thanks for reviewing, added the changelog entry accordingly. |
|
@amorde sorry for tagging, but I noticed you were recently supporting merging PRs. would you mind to please take care of this one as well? thanks in advance! |
lawchingman
approved these changes
Aug 7, 2024
amorde
approved these changes
Aug 8, 2024
|
@amorde would you mind to recheck it again and merge it? thanks! |
|
@amorde sorry for asking again, but would you mind to recheck it and merge it? thanks a lot! |
|
@segiddins would you mind to merge this PR as well? thanks! |
|
Thanks @segiddins ❤️ ! Do you know by chance if there is a plan to produce a new release as well soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
COCOAPODS_CDN_MAX_CONCURRENCYconfiguration point to reduce the maximum concurrency of Hydra. The default max concurrency (200) can lead to flakiness like DNS resolution failure being marked as DoS attack OR missing authorization headers. This flakiness is also remarked in the documentation of typhoeus library.