Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example configuration for YR #36

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Example configuration for YR #36

merged 1 commit into from
Jan 8, 2024

Conversation

MortonPL
Copy link
Member

@MortonPL MortonPL commented Jul 8, 2023

This PR provides an example configuration for Yuri's Revenge and YR-based modifications. It's targeting branch tsclient for now to minimize diff, but, once complete, it should ideally become an upstream branch.

Current configuration contains most of the necessary map making things, but it is currently missing mission scripting data like new trigger events, actions and script actions.

@Rampastring Rampastring force-pushed the tsclient branch 11 times, most recently from 2cb6ea7 to ead23f5 Compare September 2, 2023 15:48
@MortonPL MortonPL changed the base branch from tsclient to yr September 2, 2023 17:33
@MortonPL MortonPL marked this pull request as ready for review September 2, 2023 19:22
@ZivDero
Copy link
Collaborator

ZivDero commented Dec 27, 2023

Removed all the code changes from this branch, now it only consists of config changes. (Except for the last few commits, consider splitting them).
Rebased onto the latest TS config.

@@ -134,7 +134,7 @@ Description=Reveals all cells that share the same zone as the waypoint specified
P2Type=Waypoint

[PlaySound]
Name=Play sound
Name=Play Sound
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like both trigger/script action names and descriptions to be uniform across editor configurations, for the actions that are shared between TS and YR. If you feel they can be improved, make a PR for it targeting master rather than editing them for YR alone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like both trigger/script action names and descriptions to be uniform across editor configurations, for the actions that are shared between TS and YR. If you feel they can be improved, make a PR for it targeting master rather than editing them for YR alone.

I totally agree. Will need to put some thought into stadardizing it, though, as rn it's a mish-mash of FA2/FS, ModEnc and "freestyle".

Co-authored-by: MortonPL <23420063+mortonpl@users.noreply.github.com>
@Rampastring Rampastring merged commit a51465b into CnCNet:yr Jan 8, 2024
1 check passed
@MortonPL MortonPL deleted the config/yr branch January 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants