Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker_installation.md #42

Closed
wants to merge 1 commit into from

Conversation

mkania-cisco
Copy link

Tags are outdated:

Screenshot 2022-05-22 at 21 44 14

@asimpleidea asimpleidea self-requested a review May 23, 2022 12:56
@asimpleidea asimpleidea self-assigned this May 23, 2022
@asimpleidea asimpleidea added the documentation Improvements or additions to documentation label May 23, 2022
@asimpleidea
Copy link
Member

asimpleidea commented May 23, 2022

Thanks for your contribution @mkania0 and for discovering this!

We will have to change that section of the doc to not have any reference to a hard-coded version as it will be too much of hassle to change it every time we release a new version. See #43.

For now I am going to just close this as it will not be sustainable to keep having hard-coded references.

Thanks again!

@ljakab
Copy link
Member

ljakab commented May 24, 2022

Also, I think we should switch to ghcr.io in our documentation too, since that is our new canonical container registry, even if we still continue pushing to Docker Hub too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants