Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader doesn't log 200/204 coming from the Adaptor sometimes #9

Open
arnatal opened this issue Sep 23, 2020 · 3 comments
Open

Reader doesn't log 200/204 coming from the Adaptor sometimes #9

arnatal opened this issue Sep 23, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@arnatal
Copy link
Member

arnatal commented Sep 23, 2020

Under certain conditions (unclear yet) the Reader seems to not log (maybe not even receive?) the 200 or 204 confirmations from the Adaptor, while other response codes like 207 or 503 are logged. Further investigation is required.

@arnatal arnatal added the bug Something isn't working label Sep 23, 2020
@ljakab
Copy link
Member

ljakab commented Dec 17, 2020

I would have to investigate this further, but my educated guess is that it is timeout related. When the adaptor receives an event, it handles it synchronously and doesn't send a reply to the reader until it is able to apply the changes to vManage. If this takes longer than the timeout set in the reader, the reply may be missed.

@asimpleidea
Copy link
Member

asimpleidea commented Dec 17, 2020

I would have to investigate this further, but my educated guess is that it is timeout related. When the adaptor receives an event, it handles it synchronously and doesn't send a reply to the reader until it is able to apply the changes to vManage. If this takes longer than the timeout set in the reader, the reply may be missed.

Maybe, but I doubt the time out is involved because no timeout error is thrown by the cnwan reader, it just doesn't receive the response from the OpenAPI generated code as if no response was even sent but just continues working as usual.
I need to re-read that part of the code and/or the OpenAPI yaml.

@asimpleidea
Copy link
Member

Adding a bit more to the conversation:

  • every other code comes immediately, it's just 200 and 204 that do not
  • when both reader and adaptor run on the same machine, then this error does not happen and every response code is caught immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants