Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuration via a config file (e.g. YAML) #3

Closed
arnatal opened this issue Aug 27, 2020 · 1 comment · Fixed by #16
Closed

Support configuration via a config file (e.g. YAML) #3

arnatal opened this issue Aug 27, 2020 · 1 comment · Fixed by #16
Assignees
@asimpleidea
Labels
enhancement New feature or request

Comments

@arnatal
Copy link
Member

arnatal commented Aug 27, 2020

Currently, the CNWAN Reader has to be configured via CLI arguments. It might be interesting to have the possibility to provide the configuration via a, for instance, YAML file.
@arnatal arnatal added the enhancement New feature or request label Aug 27, 2020
asimpleidea added a commit to asimpleidea/cnwan-reader that referenced this issue Aug 27, 2020
@asimpleidea
Mark metadata-key flag as required (CloudNativeSDWAN#3)
b19f0e9 
This commit removes the default value for the `--metadata-key` flag
(previously, when not set, it would assume the default value `profile`).

Nonetheless, it has been marked as a required flag, as it is a critical
parameter for the the program.

Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea added a commit to asimpleidea/cnwan-reader that referenced this issue Aug 27, 2020
@asimpleidea
ServiceDirectory: mark flags as required (CloudNativeSDWAN#3)
890f3fa 
`region` and `project` are now required flags. This doesn't change much the
behavior of the program, as an error was being thrown when they were
empty even before this change.

Labelling them as required will now make the framework always
display the usage when they are empty.
Also, this frees us from having to validate them explicitly.

Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea added a commit to asimpleidea/cnwan-reader that referenced this issue Aug 27, 2020
@asimpleidea
Move credentials flag to servicedirectory command (CloudNativeSDWAN#3)
814f39a 
In an effort to make the CLI more descriptive, this commit removes the
`--credentials` flag from the root command and moves it to the
`servicedirectory` command with new name `--service-account`.
With this change the `--service-account` flag now becomes a *local* flag,
not a global one as was `--credentials` before.

This is because Google Cloud documentation always talks about
*Service Account* rather than credentials, so this change should help
anyone understand the command at first glimpse.

Readme will be updated in next commit.

Signed-off-by: Elis Lulja <elulja@cisco.com>
asimpleidea added a commit to asimpleidea/cnwan-reader that referenced this issue Aug 27, 2020
@asimpleidea
Update Readme with instructions on new flag (CloudNativeSDWAN#3)
72cf257 
The Readme is now updated with usage on `--service-account`
instead of `--credentials`.

Some other sentences have been rephrased to improve readability.

Signed-off-by: Elis Lulja <elulja@cisco.com>
@asimpleidea
Copy link
Member

asimpleidea commented Nov 16, 2020 •
edited
Loading

#4 will benefit from this very much, as specifying them via CLI is going to bring much headache

@asimpleidea asimpleidea mentioned this issue Nov 23, 2020
Merged
@asimpleidea asimpleidea linked a pull request Nov 23, 2020 that will close this issue
Introduce configuration file #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asimpleidea asimpleidea

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce configuration file asimpleidea/cnwan-reader
2 participants
@arnatal @asimpleidea