Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealisticBiomes loses connection to database #10

Open
ghost opened this issue Feb 15, 2015 · 14 comments
Open

RealisticBiomes loses connection to database #10

ghost opened this issue Feb 15, 2015 · 14 comments

Comments

@ghost
Copy link

ghost commented Feb 15, 2015

This has been needed for some time. If we are going to do sharding, then we will need to get this fixed anyway so consider it normal priority as part of sharding development.

@ttk2
Copy link

ttk2 commented Feb 15, 2015

agreed. Also we might want to consider moving it to Reddis, probably not
worth it currently, but if there are issues with the ram cache, Reddis is a
keystore, so just use the chunk chords as the key and plants as the
content, since reddis ram caches it will handle all of that, with no other
dependencies it would be an easy conversion and might some day be easier
than improving the ram cache if needed.

On Sat Feb 14 2015 at 6:36:37 PM Dr. Andrew Jawa notifications@github.com
wrote:

This has been needed for some time. If we are going to do sharding, then
we will need to get this out of the way anyway so consider normal priority
as part of sharding development.


Reply to this email directly or view it on GitHub
#10.

@erocs
Copy link

erocs commented Feb 15, 2015

You'd still have the latency of talking to the reddis server vs. in-proc memory access. You would also need to setup reddis to persist this storage. And that's another potential data store you need to backup and maintain.

@ttk2
Copy link

ttk2 commented Feb 15, 2015

good points, the additional latency is probably reason enough alone. Reddis
does not persist by default?

On Sat Feb 14 2015 at 6:44:35 PM erocs notifications@github.com wrote:

You'd still have the latency of talking to the reddis server vs. in-proc
memory access. You would also need to setup reddis to persist this storage.
And that's another potential data store you need to backup and maintain.


Reply to this email directly or view it on GitHub
#10 (comment)
.

@erocs
Copy link

erocs commented Feb 15, 2015

It does... every 5 minutes by default with RDB. You'd want to enable both persistence layers, AOF and RDB, since AOF gives the ability to save every second. Then you'd backup the RDB unless there was a reddis/VM crash and the AOF needed to be used.

@ttk2
Copy link

ttk2 commented Feb 15, 2015

every 5 minutes sounds pretty ok, one second saving might be a bit much.

On Sat Feb 14 2015 at 6:57:20 PM erocs notifications@github.com wrote:

It does... every 5 minutes by default with RDB. You'd want to enable both
persistence layers, AOF and RDB, since AOF gives the ability to save every
second. Then you'd backup the RDB unless there was a reddis/VM crash and
the AOF needed to be used.


Reply to this email directly or view it on GitHub
#10 (comment)
.

@plebes
Copy link

plebes commented Jun 13, 2015

Is this still a bug? If so, is it for certain a problem with the RB plugin and not the database or other part of the system?

@ttk2
Copy link

ttk2 commented Jun 13, 2015

We have not gotten it in a while. I think it's fixed. Yes we know it was RB
connections expire and its the plugins job go reopen them if they do.

On Sat, Jun 13, 2015, 3:05 PM plebes notifications@github.com wrote:

Is this still a bug? If so, is it for certain a problem with the RB plugin
and not the database or other part of the system?


Reply to this email directly or view it on GitHub
#10 (comment)
.

@erocs
Copy link

erocs commented Jun 13, 2015

It should be the connection pool's job to re-open the connection. RB
doesn't use one though.

On Sat, Jun 13, 2015 at 1:12 PM, ttk2 notifications@github.com wrote:

We have not gotten it in a while. I think it's fixed. Yes we know it was RB
connections expire and its the plugins job go reopen them if they do.

On Sat, Jun 13, 2015, 3:05 PM plebes notifications@github.com wrote:

Is this still a bug? If so, is it for certain a problem with the RB
plugin
and not the database or other part of the system?


Reply to this email directly or view it on GitHub
<
#10 (comment)

.


Reply to this email directly or view it on GitHub
#10 (comment)
.

@ProgrammerDan
Copy link

Yeah I was ranting to Gipsy about the RB database code a few hours back.
It's pretty bad, but if it's working semi-stable then not priority atm.

On Sat, Jun 13, 2015 at 4:42 PM, erocs notifications@github.com wrote:

It should be the connection pool's job to re-open the connection. RB
doesn't use one though.

On Sat, Jun 13, 2015 at 1:12 PM, ttk2 notifications@github.com wrote:

We have not gotten it in a while. I think it's fixed. Yes we know it was
RB
connections expire and its the plugins job go reopen them if they do.

On Sat, Jun 13, 2015, 3:05 PM plebes notifications@github.com wrote:

Is this still a bug? If so, is it for certain a problem with the RB
plugin
and not the database or other part of the system?


Reply to this email directly or view it on GitHub
<

#10 (comment)

.


Reply to this email directly or view it on GitHub
<
#10 (comment)

.


Reply to this email directly or view it on GitHub
#10 (comment)
.

@ttk2
Copy link

ttk2 commented Jun 14, 2015

An open source connection pool setup would probably be nice across all
plugins.

On Sat, Jun 13, 2015, 10:04 PM Daniel Boston notifications@github.com
wrote:

Yeah I was ranting to Gipsy about the RB database code a few hours back.
It's pretty bad, but if it's working semi-stable then not priority atm.

On Sat, Jun 13, 2015 at 4:42 PM, erocs notifications@github.com wrote:

It should be the connection pool's job to re-open the connection. RB
doesn't use one though.

On Sat, Jun 13, 2015 at 1:12 PM, ttk2 notifications@github.com wrote:

We have not gotten it in a while. I think it's fixed. Yes we know it
was
RB
connections expire and its the plugins job go reopen them if they do.

On Sat, Jun 13, 2015, 3:05 PM plebes notifications@github.com wrote:

Is this still a bug? If so, is it for certain a problem with the RB
plugin
and not the database or other part of the system?


Reply to this email directly or view it on GitHub
<

#10 (comment)

.


Reply to this email directly or view it on GitHub
<

#10 (comment)

.


Reply to this email directly or view it on GitHub
<
#10 (comment)

.


Reply to this email directly or view it on GitHub
#10 (comment)
.

@plebes
Copy link

plebes commented Jun 18, 2015

Suggestions? BoneCP?

@erocs
Copy link

erocs commented Jun 18, 2015

I was originally thinking C3P0 but that looks like it would work too.

On Wed, Jun 17, 2015 at 10:18 PM, plebes notifications@github.com wrote:

Suggestions? BoneCP?


Reply to this email directly or view it on GitHub
#10 (comment)
.

@ttk2
Copy link

ttk2 commented Jun 18, 2015

just pick one that works and run with it.

@rourke750
Copy link

Just put in in CivModCore since thats what its used for...

On Thu, Jun 18, 2015 at 7:56 AM, ttk2 notifications@github.com wrote:

just pick one that works and run with it.


Reply to this email directly or view it on GitHub
#10 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants