-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealisticBiomes loses connection to database #10
Comments
agreed. Also we might want to consider moving it to Reddis, probably not On Sat Feb 14 2015 at 6:36:37 PM Dr. Andrew Jawa notifications@github.com
|
You'd still have the latency of talking to the reddis server vs. in-proc memory access. You would also need to setup reddis to persist this storage. And that's another potential data store you need to backup and maintain. |
good points, the additional latency is probably reason enough alone. Reddis On Sat Feb 14 2015 at 6:44:35 PM erocs notifications@github.com wrote:
|
It does... every 5 minutes by default with RDB. You'd want to enable both persistence layers, AOF and RDB, since AOF gives the ability to save every second. Then you'd backup the RDB unless there was a reddis/VM crash and the AOF needed to be used. |
every 5 minutes sounds pretty ok, one second saving might be a bit much. On Sat Feb 14 2015 at 6:57:20 PM erocs notifications@github.com wrote:
|
Is this still a bug? If so, is it for certain a problem with the RB plugin and not the database or other part of the system? |
We have not gotten it in a while. I think it's fixed. Yes we know it was RB On Sat, Jun 13, 2015, 3:05 PM plebes notifications@github.com wrote:
|
It should be the connection pool's job to re-open the connection. RB On Sat, Jun 13, 2015 at 1:12 PM, ttk2 notifications@github.com wrote:
|
Yeah I was ranting to Gipsy about the RB database code a few hours back. On Sat, Jun 13, 2015 at 4:42 PM, erocs notifications@github.com wrote:
|
An open source connection pool setup would probably be nice across all On Sat, Jun 13, 2015, 10:04 PM Daniel Boston notifications@github.com
|
Suggestions? BoneCP? |
I was originally thinking C3P0 but that looks like it would work too. On Wed, Jun 17, 2015 at 10:18 PM, plebes notifications@github.com wrote:
|
just pick one that works and run with it. |
Just put in in CivModCore since thats what its used for... On Thu, Jun 18, 2015 at 7:56 AM, ttk2 notifications@github.com wrote:
|
This has been needed for some time. If we are going to do sharding, then we will need to get this fixed anyway so consider it normal priority as part of sharding development.
The text was updated successfully, but these errors were encountered: