-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prisoners might be able to escape the end #146
Comments
It will be fine if the Sharded server is using BetterShards. |
We might need to add a timer or event handler for players who magically log in on a non-prison shard, though ... although that's more of a #131 thing. @rourke750 convinced this precise issue (portaling out) isn't an issue for Sharded servers? If so, feel free to close. We should separately address/fix #131. |
That'll only trigger if the player changes servers. The issue is for
players going through end portals. That may not matter for us but will for
other servers.
|
Will my fix just not trigger for sharded servers then? |
No because that statement will never be reached because of
|
Tested it earlier, if an imprisoned player walks into a portal, he's put into an endless dying loop |
In Sharded servers if the server that has the Prison Dimension contains portals of any kind, it might be possible for a prisoner to escape.
I made some fixes here: 78d9156 to prevent it in the SMP world case with multiple worlds on a single server; and I think it might provide some measure of protection in the Sharded case as the event would probably be similar.
However, should be checked in to. This also feels like, in the Sharded case, very similar to #131
The text was updated successfully, but these errors were encountered: