Add 5 new feature road classes to centreline #1157
Open
+100
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gabrielwol
reviewed
Feb 25, 2025
| @@ -93,17 +101,17 @@ def pull_layer(layer, conn_id): | |||
| context["table_name"] = layer[0] | |||
| #get db connection | |||
| conn = PostgresHook(conn_id).get_conn() | |||
|
|
|||
| print(layer[1].get("include_additional_feature")) | |||
Comment on lines
+655
to
+656
| LOGGER.info("include_additional_feature flag: %s", include_additional_feature) | ||
|
|
Comment on lines
+319
to
+321
| where = "\"FEATURE_CODE_DESC\" IN ('Collector','Collector Ramp','Expressway','Expressway Ramp','Local','Major Arterial','Major Arterial Ramp','Minor Arterial','Minor Arterial Ramp','Pending', 'Other', 'Trail', 'Busway', 'Laneway', 'Other Ramp', 'Access Road')" | ||
| else: | ||
| where = "\"FEATURE_CODE_DESC\" IN ('Collector','Collector Ramp','Expressway','Expressway Ramp','Local','Major Arterial','Major Arterial Ramp','Minor Arterial','Minor Arterial Ramp','Pending', 'Other')" |
There was a problem hiding this comment.
To make this section a bit more clear about what's being added, could you just have the if include_additional_feature: clause append OR feature_code_desc IN (...) to the default?
| | Local | ✅ | ✅ | | ||
| | Pending | ✅ | ✅ | | ||
| | Other (added `2024-02-19`) | ✅ | ✅ | | ||
| | Buslane (added `2025-02-24`) | ❌ | ✅ | |
| 'Other', | ||
| 'Other Ramp', | ||
| 'Laneway', | ||
| 'Pending'); |
There was a problem hiding this comment.
Add a mat view comment specifying which layers are left out?
| @@ -14,7 +14,8 @@ The centreline data are used by many other groups in the City and it's often imp | |||
|
|
|||
| ## How It's Structured | |||
|
|
|||
| * The `gis_core.centreline_latest` Materialized View contains the latest set of lines with unique id `centreline_id`. These lines are undirected. All edges have _from_ and _to_ nodes, though this should not be taken to indicate that edges are directed. For a directed centreline layer, check out `gis_core.routing_centreline_directional` ([see more](#centreline-segments-edges)) which has the necessary schema to be used in pg_routing. | |||
| * The `gis_core.centreline_latest` Materialized View contains the latest set of lines for road classes that are relevant to transportation. It includes all road classification but **excludes** `Trail` and `Buslane`. | |||
| * 'Pending' | ||
| * 'Other' (version >= `2024-02-19`) | ||
| > [!IMPORTANT] | ||
| > **2025-02-24**: Added `Buslane`, `Trail`, `Access Road`, `Other Ramp`, and `Laneway`, in order to ensure consistency with MOVE. |
|
Also we should remember to keep Bancroft gcc_puller up to date, although these changes won't affect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged