Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1149 add geojson export to ecocounter open data #1151

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

gabrielwol
Copy link
Collaborator

What this pull request accomplishes:

  • Create a view to format open data locations as geojson in postgres
  • Add new task to export the view

Issue(s) this solves:

What, in particular, needs to reviewed:

What needs to be done by a sysadmin after this PR is merged

E.g.: these tables need to be migrated/created in the production schema.

@gabrielwol gabrielwol requested a review from chmnata February 18, 2025 20:22
@gabrielwol gabrielwol self-assigned this Feb 18, 2025
@gabrielwol gabrielwol linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link
Collaborator

@chmnata chmnata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the geojson need a properties field? Can't get the geojson to dispplay on geojson.io

@gabrielwol
Copy link
Collaborator Author

does the geojson need a properties field? Can't get the geojson to dispplay on geojson.io

Weird, it opened fine in QGIS and https://geojson.tools, but looks like some tools require properties where I used attributes. I'll change that.

@radumas
Copy link
Member

radumas commented Feb 19, 2025

Can you double check what CKAN would require to display the map on an open data page?

@gabrielwol
Copy link
Collaborator Author

I made the attributes -> properties change and it works in all 4 tools I tried. I created a Jira ticket mentioning we want the map displayed as a preview on the landing page.

@gabrielwol gabrielwol merged commit b2e4c3b into master Feb 19, 2025
6 checks passed
@gabrielwol gabrielwol deleted the 1149-add-geojson-export-to-ecocounter-open-data branch February 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add geojson export to Ecocounter Open Data
3 participants