HP-2280 | Django 5.0 admin logout support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use POST for social auth logout on Django admin login page - django admin site returns logoutview response instead of redirect Django 5.0 has removed the ability to log out via GET requests in the django.contrib.auth.views.LogoutView and django.contrib.auth.views.logout_then_login(). Refs: HP-2280, https://docs.djangoproject.com/en/5.0/releases/5.0/
charn
force-pushed
the
HP-2280-logout-fix
branch
from
f44762e to
aa963e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
- Coverage 56.21% 56.12% -0.10%
==========================================
Files 31 31
Lines 1062 1062
==========================================
- Hits 597 596 -1
- Misses 465 466 +1 ☔ View full report in Codecov by Sentry. |
nicobav
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for logout in Django admin (for Django 5.0). The ability to log out via GET requests in the
django.contrib.auth.views.LogoutViewanddjango.contrib.auth.views.logout_then_login()was removed in Django 5.0.