HP-2260 | Add new session serializer for Django 5.0 support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove versions of Django and Python from tests which do not receive updates any longer. Refs: HP-2260
Django 5.0 removes PickleSerializer which was deprecated in Django 4.1. SOCIAL_AUTH_PIPELINE provided by this package needs to be able to handle a datetime field in the session data. Refs: HP-2260
Refs: HP-2260
|
Need to drop Python 3.7 from the test workflow: https://github.com/City-of-Helsinki/django-helusers/blob/master/.github/workflows/test.yml#L17 |
Refs: HP-2260
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 55.58% 56.21% +0.62%
==========================================
Files 30 31 +1
Lines 1047 1062 +15
==========================================
+ Hits 582 597 +15
Misses 465 465 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new session serializer class, which is capable of serializing an expected datetime field in the session data.
SOCIAL_AUTH_PIPELINEprovided by this package needs to be able to handle adatetimefield in the session data. Django 5.0 removesPickleSerializerwhich was deprecated earlier.This PR also drops support for old (unsupported) Python and Django versions and adds Python 3.12 and Django 5.0 to
toxtests.