Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map multiple user groups to one ad group #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikomakela
Copy link
Contributor

@nikomakela nikomakela commented Feb 7, 2025

One AD-group should be able to be mapped for multiple user groups.

This kind of mapping should be valid:

image

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9d3e0f1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage        ?   65.88%           
=======================================
  Files           ?       29           
  Lines           ?     1102           
  Branches        ?        0           
=======================================
  Hits            ?      726           
  Misses          ?      376           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

One AD-group should be able to be mapped for multiple user groups.
@nikomakela nikomakela force-pushed the multi-group-for-one-ad branch from 1a13bf8 to 2730e66 Compare February 7, 2025 08:00
@charn charn requested a review from a team February 7, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants