Rework Python tests to use pytest, enforce coverage #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily focused on improving tests on lolopy. It should include no changes to functionality.
Note that coverage is skipped on recursive calls to
_make_learners
when there are user-defined learners present. It was not clear how to exercise those routes.__get_state__
inBaseLoloLearner
to always copy the state dictionary, as the result returned from latest sklearn uses a tied dictionary, so deleting gateway corrupted the object. Also change the del to a pop so, removing the need for a try / except block.__init__
toBaseLoloClassifier
so that n_classes is not initialized outside of an__init__
methodos
topathlib