Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a viewed set drops the first character #14

Open
Cisien opened this issue Sep 16, 2021 · 0 comments
Open

Editing a viewed set drops the first character #14

Cisien opened this issue Sep 16, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Cisien
Copy link
Owner

Cisien commented Sep 16, 2021

When editing a set not in the "your sets" list, the first character is dropped and the editor loses focus.

This is due to how a set gets "promoted" to being a "Your set" instead of being ad-hoc (downloaded just to view).
The specific mechanism is that this promotion happens when the set gets marked "dirty" by typing in the editor. This happens before the content is persisted from the model, so when it's moved from the adhoc set to the uploads list, the data gets lost and the editor's model is re-generated.

Possible Fixes:

  • Grab the model contents and set that before promoting the bundle, and then re-focus the editor after the promotion is done
  • Make the editor read-only on viewed files, with a UI element for editing it. Clicking the UI element would promote the set similar to how clicking the "new" button works.
  • ???
@Cisien Cisien added the bug Something isn't working label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant