-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic simulator tutorial #313
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #313 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 55 55
Lines 2399 2399
=======================================
Hits 2211 2211
Misses 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
934c0cb
to
599e6d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome tutorial! We really needed something like this. I've added a few minor comments that should be quick to go through.
d7e8b12
to
5174f54
Compare
0b9255b
to
1a86d75
Compare
6bcc84c
to
5ea59ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've approved since it's ready to go, but there is one minor change you could make first which is just to use the caskade argument filling for psf
so that you dont need self.psf.value
in your forward method.
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
1b9e204
to
48b38c8
Compare
Please read the new tutorial in the docs (I also moved the Menagerie down)