Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic simulator tutorial #313

Merged
merged 24 commits into from
Jan 26, 2025
Merged

Basic simulator tutorial #313

merged 24 commits into from
Jan 26, 2025

Conversation

mjyb16
Copy link
Collaborator

@mjyb16 mjyb16 commented Jan 22, 2025

Please read the new tutorial in the docs (I also moved the Menagerie down)

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (abc9518) to head (958c538).
Report is 25 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #313   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          55       55           
  Lines        2399     2399           
=======================================
  Hits         2211     2211           
  Misses        188      188           
Flag Coverage Δ
unittests 92.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome tutorial! We really needed something like this. I've added a few minor comments that should be quick to go through.

Copy link
Member

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've approved since it's ready to go, but there is one minor change you could make first which is just to use the caskade argument filling for psf so that you dont need self.psf.value in your forward method.

mjyb16 and others added 2 commits January 25, 2025 19:32
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
Co-authored-by: Connor Stone, PhD <connorstone628@gmail.com>
@mjyb16 mjyb16 added the docs Improvements or additions to documentation label Jan 26, 2025
@mjyb16 mjyb16 merged commit 104bf25 into dev Jan 26, 2025
13 checks passed
@mjyb16 mjyb16 deleted the tutorial_misha branch January 26, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants