Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Develop Branch - Merge #67 [API 7] Event valueType text breaks SpecUtils, Java Sample #75

Open
DissonantAU opened this issue Feb 8, 2025 · 1 comment
Open

[BUG] Develop Branch - Merge #67 [API 7] Event valueType text breaks SpecUtils, Java Sample #75

DissonantAU opened this issue Feb 8, 2025 · 1 comment

Comments

@DissonantAU
Copy link

It looks like some changes to #67 break SpecUtils and the Java Sample

It looks like valueType was added to Event.java, then removed in favour of auto-detecting the type but some things were missed in the change:

SpecUtils

  • Function createEventTypeSpecBuilder Tries to use Event.valueType for adding a field
    TouchPortalSampleJavaPlugin
  • customStateWithEvent and stateWithEventTypeText still have the valueType Annotation
  • The comment for customStateWithEventInSubCat is missing the starting line /**
@DissonantAU
Copy link
Author

Fixes applied in branch here:
https://github.com/DissonantAU/TouchPortalPluginSDK/tree/develop-valueType-fix

@DissonantAU DissonantAU mentioned this issue Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DissonantAU