utility additions to ImmediateValuePromise #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They get and take a "Option<Result<_, _>>" object out of the DirectCacheAccess implementor. When None the status was updating or blank and if the result is present the status was success or error.
makes it easier to work with ImmediateValuePromise's since all that is needed to create one is a ".into()".
|
Thanks for the PR, will review this evening :) |
|
This looks super convenient. Could you please fix the pipeline-errors and add an example for the new methods? A doctest could just work fine here. |
|
Sorry I didn't get to it, should I open a new PR with the doc additions? |
|
@tomellm nevermind, had some time and fixed everything after merge. New version is already released as 0.6.0. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using
lazy_async_promisewith a lot of success for a while I noticed that these two things would be useful additions to the toolset.1.
get_resultandtake_resultI often find myself working with promises where I wait for them to stop updating after which I wan't to get the success or the error value which is where these functions have come very much in handy.
2.
impl From<T: std::future::Future + Send + 'static>This might be personal preference but I dislike the constant wrapping of futures to create
ImmediateValuePromise's so I implemented the theFromtrait forT: std::future::Future + Send + 'staticfor very easy conversion with.into().I don't know if this proposal is a bit unsolicited but I much enjoy using this crate and would love to make it even more useful in my eyes. If there are tests I should add or changes I should make feel free to tell me so.