Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for thumbnails. #2

Open
dheerajdlalwani opened this issue May 7, 2022 · 6 comments · May be fixed by #66
Open

feat: Support for thumbnails. #2

dheerajdlalwani opened this issue May 7, 2022 · 6 comments · May be fixed by #66
Assignees
Labels
feature New features or requests
Milestone

Comments

@dheerajdlalwani
Copy link
Member

No description provided.

@dheerajdlalwani dheerajdlalwani added enhancement Improvements in UI, UX or features feature New features or requests and removed enhancement Improvements in UI, UX or features labels May 8, 2022
@chiraglulla chiraglulla added this to the pre UI revamp milestone Feb 2, 2025
@chiraglulla chiraglulla changed the title feat: Support for uploading thumbnails. feat: Support for thumbnails. Feb 2, 2025
@dheerajdlalwani dheerajdlalwani self-assigned this Feb 11, 2025
@dheerajdlalwani
Copy link
Member Author

Hey @chiraglulla

I am planning to pick this up, and will be clubbing this issue with #63 because I feel thumbnails would go great with the Grid view UI wise.

What do you think?

Also, we have 3-4 options for the thumbnail.

  1. We take the first frame of of the video and extract that as the thumbnail
  2. Take the 1st 50 or so frames and pick one frame at random.
  3. letting the users upload their own thumbnail.

What do you think?

I also am considering a default thumbnail for existing videos + for videos where we couldn't extract the thumbnail.

@chiraglulla
Copy link
Member

chiraglulla commented Feb 11, 2025

Regarding the clubbing of 2 issues, I would say go with atomic issues, close them and move forward. Let's achieve our discussed milestone step by step.

  1. We take the first frame of the video and extract that as the thumbnail -- good initial implementation
  2. Take the 1st 50 or so frames and pick one frame at random -- instead of random selection, we can display the 50 frames or so to the user in a decent UX and let them choose from all.
  3. letting the users upload their own thumbnail -- eventually this has to be there, sure.

I also am considering a default thumbnail for existing videos + for videos where we couldn't extract the thumbnail.
-- Can't we process them separately now and get the thumbnail resource out of it?

@dheerajdlalwani
Copy link
Member Author

dheerajdlalwani commented Feb 11, 2025

Alrighty, that makes sense.
Will pick up only thumbnail for now and going with our first iteration: Will pick up the first frame from the video.

about thumbnails for the existing videos, yes that was the plan -> running a separate script to extract thumbnails for existing videos, but by the time we do that, they will have the existing default thumbnails.

@chiraglulla
Copy link
Member

Cool.

@dheerajdlalwani
Copy link
Member Author

Alrighty, I'll raise a draft PR right way.

@dheerajdlalwani dheerajdlalwani linked a pull request Feb 11, 2025 that will close this issue
@chiraglulla
Copy link
Member

Not sure if it applies here.
But try to develop this feature as a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants