Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup test_db_validate_default_1000_blocks() #19222

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fixup test_db_validate_default_1000_blocks() #19222

merged 2 commits into from
Feb 4, 2025

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 3, 2025

Purpose:

introduced in: #19182
repeated tested at: https://github.com/Chia-Network/chia-blockchain/actions/runs/13123877684

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner February 3, 2025 22:17
@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Feb 3, 2025
Copy link

coveralls-official bot commented Feb 3, 2025

Pull Request Test Coverage Report for Build 13125785527

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.539%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.24%
chia/farmer/farmer.py 1 73.37%
chia/daemon/client.py 1 74.16%
chia/plotters/plotters.py 1 90.94%
chia/full_node/full_node_api.py 1 84.38%
chia/full_node/full_node.py 1 86.54%
chia/_tests/core/util/test_lockfile.py 4 88.43%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 13117920682: 0.02%
Covered Lines: 105263
Relevant Lines: 114815

💛 - Coveralls

@altendky
Copy link
Contributor Author

altendky commented Feb 3, 2025

I'll propose we merge through the unrelated bladebit harvester error.

https://github.com/Chia-Network/chia-blockchain/actions/runs/13123934217/job/36616905095?pr=19222

ImportError: libbladebit_harvester-493b39b7.so: cannot enable executable stack as shared object requires: Invalid argument

Quexington
Quexington previously approved these changes Feb 3, 2025
@pmaslana pmaslana merged commit 1d9ab3c into main Feb 4, 2025
363 of 364 checks passed
@pmaslana pmaslana deleted the fixup_again branch February 4, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants