Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] mask avatars don't display properly in many areas #3965

Closed
2 of 3 tasks
lainbo opened this issue Feb 1, 2024 · 10 comments
Closed
2 of 3 tasks

[Bug] mask avatars don't display properly in many areas #3965

lainbo opened this issue Feb 1, 2024 · 10 comments

Comments

@lainbo
Copy link

lainbo commented Feb 1, 2024

Describe the bug
Mask avatars are not displayed properly. The reason is that the cdn cdn.jsdelivr.net that we use for avatars, has problems resolving in some regions, it can be changed to another cdn, I can provide the PR

To Reproduce

  1. People in some provinces in mainland China (the exact provinces will be given at the end of the issues).
  2. Open the mask page

Expected behavior
The mask's avatar can be displayed normally

Screenshots
image

Deployment

  • Docker
  • Vercel
  • Server

Desktop (please complete the following information):

  • It's not about the equipment

Smartphone (please complete the following information):

  • It's not about the equipment

Additional Logs
In this PR, the CDN of staticfile was changed to jsdelivr, and the cdn.jsdelivr.com is completely unavailable in some provinces of mainland China (as shown in the following picture). The staticfile cdn before this PR can actually continue to be used, the previous can not be used because they changed the domain name (org → net). So I suggest changing the CDN back to staticfile. This will ensure that users in all provinces of mainland China can see the avatar image.

Just change the code in this line to following

return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

As you can see, cdn.jsdelivr.net is inaccessible in many Mainland China provinces!
image

@H0llyW00dzZ
Copy link
Contributor

something wrong in your network

works fine here

image

@H0llyW00dzZ
Copy link
Contributor

also about

return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

does that CDN can handle high loads or whatever it is ?

@lainbo
Copy link
Author

lainbo commented Feb 1, 2024

something wrong in your network

works fine here

image

Thank you for your reply, please see the last picture I posted above, or go to this website for testing, there are quite a lot of provinces in mainland China that can't connect using the current CDN cdn.jsdelivr.net, but there are some that can be used normally, it may be caused by GFW cause, you can search on the network to find a lot of this cdn by gfw blocking discussion

@lainbo
Copy link
Author

lainbo commented Feb 1, 2024

also about

return `https://cdn.staticfile.net/emoji-datasource-apple/15.0.1/img/${style}/64/${unified}.png`;

does that CDN can handle high loads or whatever it is ?

First of all, to answer your question, this CDN was used before this project, but then access failed due to a problem with its domain name (see image below), and then it was replaced with the current CDN (cdn.jsdelivr.net). PR history

image

Since we used to be able to use it, it shouldn't be a problem to change it back now and fix the domain name correctly.


If you are not sure about this change, we can also make a minimal change to use fastly.jsdelivr.net, this CDN and the current cdn.jsdelivr.net is the same provider, although in some provinces in mainland China packet loss is relatively high, but the connectivity is not a problem, to provide exactly the same load capacity!

Connectivity testing for fastly.jsdelivr.net
Connectivity testing for staticfile.net

@lainbo
Copy link
Author

lainbo commented Feb 1, 2024

Summary of my speech:

  • The reason for using staticfile.net is because Next Chat had previously used it, providing first-rate CDN support for all provinces in mainland China
  • The reason for using fastly.jsdelivr.net is that it is the same CDN provider currently used in our project, offering basically enough CDN support for all provinces in mainland China

@H0llyW00dzZ
Copy link
Contributor

Summary of my speech:

  • The reason for using staticfile.net is because Next Chat had previously used it, providing first-rate CDN support for all provinces in mainland China
  • The reason for using fastly.jsdelivr.net is that it is the same CDN provider currently used in our project, offering basically enough CDN support for all provinces in mainland China

yeah but it was down, and I'm not certain if it's stable again. For instance, I'm unsure if it can handle high volumes of traffic about old CDN

@lainbo
Copy link
Author

lainbo commented Feb 1, 2024

Then you can try using fastly.jsdelivr.net, which is the same service provider as cdn.jsdelivr.net in the current project. It has the same capacity for handling traffic and can provide services to all provinces in mainland China.

@H0llyW00dzZ
Copy link
Contributor

Then you can try using fastly.jsdelivr.net, which is the same service provider as cdn.jsdelivr.net in the current project. It has the same capacity for handling traffic and can provide services to all provinces in mainland China.

alright

@H0llyW00dzZ
Copy link
Contributor

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


  • ChatGPT NextWeb#3966

@fred-bf fred-bf closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants