-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update BeaconBlocksByRoot/Range rate limits to use deneb value #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7409 +/- ##
=========================================
Coverage 48.44% 48.44%
=========================================
Files 602 602
Lines 40407 40407
Branches 2068 2069 +1
=========================================
+ Hits 19576 19577 +1
+ Misses 20793 20792 -1
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
approved these changes
Jan 30, 2025
🎉 This PR is included in v1.26.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #7405 we have access to fork name and can apply correct rate limits to BeaconBlocksByRoot/Range, we wanna use
MAX_REQUEST_BLOCKS_DENEB
consistently for both methods since Deneb.