Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Tipset passed to new_eth_tx_receipt #5205

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Jan 30, 2025

Summary of changes

Changes introduced in this pull request:

  • Fix flakyness in Filecoin.EthGetTransactionReceipt and Filecoin.EthGetTransactionReceiptLimited methods, because wrong tipset was sometimes passed to new_eth_tx_receipt.

Reference issue to close (if applicable)

Closes #4996

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review January 30, 2025 13:34
@elmattic elmattic requested a review from a team as a code owner January 30, 2025 13:34
@elmattic elmattic requested review from lemmih and LesnyRumcajs and removed request for a team January 30, 2025 13:34
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock solid!

@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 778a39c Feb 4, 2025
43 checks passed
@hanabi1224 hanabi1224 deleted the elmattic/fix-tx-receipt branch February 4, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RPC] Flaky Filecoin.EthGetTransactionReceipt and Filecoin.EthGetTransactionReceiptLimited tests
3 participants