Friendship overrides other configured permissions #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a profile has marked another profile as "friendly", then they want to befriend that profile, and we should prioritize that over any other permission constraints they've placed such as confirmed emails, etc. With the exception of myself - where friends are explicitly excluded.
* Allow :focus to be used in tests * Use documentation format automatically when one file is run
ChaelCodes
force-pushed
the
perms-for-friends
branch
from
1ab3482 to
3ce2580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Feature or Issue
If the profile has befriended another profile, they are explicitly saying they want to be friends, and sharing their information - even if they normally don't allow unconfirmed users to view their profile - is ideal.
Bonus
:focusworks in RSpec, and documentation format will be used if only one file is run.Checklist
User-Facing Changes
Unauthenticated user who is friended by a profile can view/access that profile.