Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial reload support #194

Open
DerpyNewbie opened this issue Apr 30, 2024 · 2 comments · May be fixed by #252
Open

Add partial reload support #194

DerpyNewbie opened this issue Apr 30, 2024 · 2 comments · May be fixed by #252
Labels
approved This issue is approved to be implemented enhancement New feature or request
Milestone

Comments

@DerpyNewbie
Copy link
Contributor

DerpyNewbie commented Apr 30, 2024

Expected to release after 0.6, but before 0.7.

  • Gun provides some methods to handle reloading, but these are not tested since it always returns the same value.
  • Add reloading system #185 is expected to release in 0.7.0, but it still requires lots of work, and may take more than a year for release.
  • Adding simple guns-down reload system will open up many choices available to system users,
    and might be significant enough to change current VRChat airsoft scene.

Original idea came from talking to ルシファーさん talking about reloading system.

Specification

  • Gun will have these properties
    • TotalBulletsRemaining
      • In reserve
    • CurrentBulletsRemaining
      • In magazine
    • InitialTotalBullets
    • ReloadTimeInSeconds
  • ManagedGun's InitialTotalBullets can be configured when summoning
  • TotalBulletsRemaining can be reset to InitialTotalBullets with some kind of methods
@DerpyNewbie DerpyNewbie added the enhancement New feature or request label Apr 30, 2024
@DerpyNewbie DerpyNewbie added the waiting-review Waiting for review label Jul 3, 2024
@Nuinomi Nuinomi added the question Further information is requested label Jul 4, 2024
@Nuinomi
Copy link

Nuinomi commented Jul 4, 2024

リロードシステムの追加#185 が追加されるまでの繋ぎの簡易的なリロードシステムという認識で問題ないですか?

@DerpyNewbie
Copy link
Contributor Author

@Nuinomi その認識で問題ないです!

@Nuinomi Nuinomi added approved This issue is approved to be implemented and removed question Further information is requested waiting-review Waiting for review labels Jul 5, 2024
@DerpyNewbie DerpyNewbie added this to the 1.0.0 milestone Sep 3, 2024
@DerpyNewbie DerpyNewbie linked a pull request Oct 1, 2024 that will close this issue
6 tasks
@DerpyNewbie DerpyNewbie linked a pull request Oct 1, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is approved to be implemented enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants