Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change footstep playing method #153

Open
DerpyNewbie opened this issue Feb 2, 2024 · 0 comments
Open

Change footstep playing method #153

DerpyNewbie opened this issue Feb 2, 2024 · 0 comments
Assignees
Labels
approved This issue is approved to be implemented breaking-change Breaking changes that requires users migration enhancement New feature or request
Milestone

Comments

@DerpyNewbie
Copy link
Contributor

Problem

Currently we're playing footsteps using PlayerModel's Play{ObjectType}FootstepAudio|PlaySlow{ObjectType}FootstepAudio methods.
Because of this, We cannot dynamically add ObjectTypes without changing PlayerModel.

Solution

We could create new FootstepPlayer.

PlayerBase classes reference it, and calls FootstepPlayer#PlayFootstep(Transform playerTransform, bool isSlow) via new PlayerBase#PlayFootstep|PlayerBase#PlaySlowFootstep PlayerBase API

FootstepPlayer#PlayFootstep(Transform playerTransform, bool isSlow) should play footstep by raycasting down from provided transform.

@DerpyNewbie DerpyNewbie added enhancement New feature or request breaking-change Breaking changes that requires users migration labels Feb 2, 2024
@DerpyNewbie DerpyNewbie added this to the 0.7.0 milestone Feb 2, 2024
@DerpyNewbie DerpyNewbie self-assigned this Feb 2, 2024
@DerpyNewbie DerpyNewbie changed the title Consider changing footstep playing method Change footstep playing method Feb 2, 2024
@DerpyNewbie DerpyNewbie added the waiting-review Waiting for review label Jul 3, 2024
@Nuinomi Nuinomi added approved This issue is approved to be implemented and removed waiting-review Waiting for review labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is approved to be implemented breaking-change Breaking changes that requires users migration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants