Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: CLPVG #3

Open
rnjv opened this issue Feb 3, 2022 · 3 comments
Open

FR: CLPVG #3

rnjv opened this issue Feb 3, 2022 · 3 comments

Comments

@rnjv
Copy link

rnjv commented Feb 3, 2022

Feature Request to add LPVG and CLPVG
Ref: https://aip.scitation.org/doi/10.1063/5.0048243

@CarlosBergillos
Copy link
Owner

CarlosBergillos commented Feb 6, 2023

Hi!

I just added support for LPVGs via the penetrable_limit paramter (ts2vg>=1.2.0).
You can find an example here: Building limited penetrable visibility graphs

Circular visibility graphs (CLPVG) seem to be more challenging to implement, since they work quite differently compared to the others. I'll investigate further but I can't promise I have the time to implement it sorry.

I'll leave the issue open in case it can be implemented eventually.

@wisewu11
Copy link

+1!!Thank you very much for the code provided by the blogger, I benefited a lot. Hope to get out the CLPVG code soon!!

@CarlosBergillos
Copy link
Owner

CarlosBergillos commented Mar 4, 2023

Hi, I've started prototyping some naive implementations for CLPVG and I'm exploring some different strategies to compute them.

@wisewu11, @rnjv, are you familiar with CLPVG? have you worked with them?
I have some questions regarding its definition and its "alpha" hyperparameter that I would like to discuss.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants