Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in checking fix type #52

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Add back in checking fix type #52

merged 3 commits into from
Jun 9, 2024

Conversation

AngusJull
Copy link
Contributor

Added some code for checking the fix type before transmitting height or lat/lon. I want to switch the message we poll to the NAV-PVT message to make this look better and work better, but I'll include that in another PR.

@AngusJull AngusJull requested a review from linguini1 as a code owner June 8, 2024 17:52
@AngusJull AngusJull self-assigned this Jun 8, 2024
Copy link
Collaborator

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but I'd prefer we don't send the fix information, we just use it internally to determine whether or not coordinates are safe to send. If you want to leave the code in case we can just comment it out. Just right now I have no encoding for that message to be sent.

I wouldn't be opposed about sending it later, but I don't want to add another packet to the spec for this yet. I think it would fit better under a status type rather than a data type, alongside something like SNR measurements, etc.

@linguini1
Copy link
Collaborator

Merged in logging changes from main. I will merge this branch to main and just remove the sending of fix data over the message queue from main for now. The branch will remain otherwise untouched in case we add it to the spec later and want to send it.

@linguini1 linguini1 merged commit 5c89823 into main Jun 9, 2024
1 check passed
@linguini1 linguini1 deleted the validate-fixes branch June 9, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants