Add some remaining M10SPG suggestions #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linguini1
reviewed
Jun 2, 2024
src/collectors/m10spg_clctr.c
Outdated
| uint32_t U32; /**< The message payload, interpreted as a uin32_t */ | ||
| int32_t I32; /**< The message payload, interpreted as a int32_t */ | ||
| uint8_t U8; /**< The message payload, interpreted as a uint8_t */ | ||
| vec2d_t VEC2D; /**< The message payload, interpreted as a vec2d_t */ |
There was a problem hiding this comment.
I should mention that even with the packed attribute, I've found that the float members within vec2d_t and float get padded. For those measurements you will unfortunately have to use the uint8_t buffer with some pointer casting. I'm not sure if adding packed to the union would help, but you could try and see if packager can still receive the data properly?
There was a problem hiding this comment.
I've added a common type for fetcher, I'll start on adding it to packager. Then we can see if it'll work or not.
linguini1
requested changes
Jun 2, 2024
AngusJull
force-pushed
the
m10spg-suggestions
branch
from
233c752 to
b43d727
Compare
Since the underlying data is encoded as ints, simply copying into memory interpreted as floats will cause corruption of data
AngusJull
force-pushed
the
m10spg-suggestions
branch
from
b43d727 to
481b3e7
Compare
A temporary measure to ensure no floating point math is preventing gps data from getting through
AngusJull
force-pushed
the
m10spg-suggestions
branch
from
41fdcf6 to
85097b3
Compare
linguini1
force-pushed
the
m10spg-suggestions
branch
from
93cd708 to
95534fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed leftover suggestions from #22 that I think were missed, as well as fixed the casting of values from ints to floats which should make the GPS data more understandable