From ea14a472b5c7c97e496237f61a209b0faedfce00 Mon Sep 17 00:00:00 2001 From: AngusJull Date: Sat, 1 Jun 2024 21:36:28 -0400 Subject: [PATCH] Use defines instead of raw hex for config keys --- src/drivers/m10spg/m10spg.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/drivers/m10spg/m10spg.c b/src/drivers/m10spg/m10spg.c index d583d58..b58bc2f 100644 --- a/src/drivers/m10spg/m10spg.c +++ b/src/drivers/m10spg/m10spg.c @@ -35,6 +35,12 @@ /** How long m10spg_read should wait for a response in seconds */ #define DEFAULT_TIMEOUT 10 +/** A configuration key for enabling or disabling output of NMEA messages on I2C */ +#define NMEA_I2C_OUTPUT_CONFIG_KEY 0x10720002 + +/** A configuration key for enabling or disabling input of poll requests for NMEA messages on I2C */ +#define NMEA_I2C_INPUT_CONFIG_KEY 0x10710002 + static const UBXFrame PREMADE_MESSAGES[] = { [UBX_NAV_UTC] = {.header = {.class = 0x01, .id = 0x21, .length = 0x00}, .checksum_a = 0x22, .checksum_b = 0x67}, [UBX_NAV_POSLLH] = {.header = {.class = 0x01, .id = 0x02, .length = 0x00}, .checksum_a = 0x03, .checksum_b = 0x0a}, @@ -305,9 +311,9 @@ int m10spg_open(const SensorLocation *loc) { init_valset_message(&msg, RAM_LAYER); uint8_t config_disabled = 0; // Disable NMEA output on I2C - add_valset_item(&msg, (uint32_t)0x10720002, &config_disabled, UBX_TYPE_L); + add_valset_item(&msg, (uint32_t)NMEA_I2C_OUTPUT_CONFIG_KEY, &config_disabled, UBX_TYPE_L); // Disable NMEA input on I2C - add_valset_item(&msg, (uint32_t)0x10710002, &config_disabled, UBX_TYPE_L); + add_valset_item(&msg, (uint32_t)NMEA_I2C_INPUT_CONFIG_KEY, &config_disabled, UBX_TYPE_L); calculate_checksum(&msg, &msg.checksum_a, &msg.checksum_b); int err = send_message(loc, &msg);