GitHub Actions workflow improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow manual triggering of this workflow. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
This is duplicative of the project's default settings.
The biggest change here is that the workflow now uses the CargoSense/setup-elixir-project reusable Action.
This required using an older version of Ubuntu to support older Erlang/OTP versions. Pulled that bit of knowledge from the README here: https://github.com/erlef/setup-beam Additionally, Erlang/OTP compatibility charts are maintained here: https://hexdocs.pm/elixir/compatibility-and-deprecations.html#between-elixir-and-erlang-otp …and lastly, the matrix expansion via `include` is documented here: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations I'm _mostly_ confident this will work as desired.
|
I suspect the changes to this workflow aren't running as part of the PR status checks because I renamed the file. 🤦🏻 |
billylanchantin
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing CI workflow. Notable changes include:
ci.ymlto better reflect its function,workflow_dispatchas an event trigger so that we may manually invoke the Action (should that prove useful)I've retained the use of a matrix even though there's only one configured OTP and Elixir version. @billylanchantin and I have been chatting about what an improved test matrix might look like, but haven't yet come to a conclusion. One we do, I'm happy to update the matrix with additional versions.Updated in c9e6068. Pulling out my commit message since it includes some relevant notes: