Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): implement previous selection audio and camera #124

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

r17x
Copy link
Contributor

@r17x r17x commented Oct 18, 2024

Changes

  • Change API of createOptionsQuery
    • add setOptions: is same with commands.setRecordOptions.
  • Change commands.setRecordOptions to --> setOptions

Screen Record

cap.mp4

/claim #123

Copy link

vercel bot commented Oct 18, 2024

@r17x is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@@ -4,7 +4,6 @@ import { createEventListener } from "@solid-primitives/event-listener";
import { cache, createAsync, redirect, useNavigate } from "@solidjs/router";
import { createMutation, createQuery } from "@tanstack/solid-query";
import { getVersion } from "@tauri-apps/api/app";
import { Window } from "@tauri-apps/api/window";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richiemcilroy Removed unused

export function createOptionsQuery() {
const options = createQuery(() => getOptions);
const KEY = "recordingOptionsQuery"
const localState = localStorage.getItem(KEY);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using localStorage for save value camera and audio.

@r17x r17x force-pushed the feat/prev-selection branch from 7a6421a to 18bf76e Compare October 18, 2024 00:54
@r17x r17x force-pushed the feat/prev-selection branch from 18bf76e to d68f15c Compare October 18, 2024 00:58
@r17x r17x changed the title feat(desktop): implemenet previous selection audio and camera feat(desktop): implement previous selection audio and camera Oct 18, 2024
@richiemcilroy
Copy link
Collaborator

looks great!

@richiemcilroy richiemcilroy merged commit e4ef845 into CapSoftware:main Oct 19, 2024
0 of 2 checks passed
@r17x r17x deleted the feat/prev-selection branch October 19, 2024 17:35
@richiemcilroy
Copy link
Collaborator

/tip $100

Copy link

algora-pbc bot commented Nov 28, 2024

Copy link

algora-pbc bot commented Nov 28, 2024

🎉🎈 @r17x has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants